FlutterFragment predictive back #44865
Conversation
justinmc
force-pushed
the
flutter-fragment-predictive-back
branch
3 times, most recently
from
0718e5c
to
e2ff310
Compare
justinmc
force-pushed
the
flutter-fragment-predictive-back
branch
from
e2ff310
to
89629fb
Compare
| // can be changed by calling setFrameworkHandlesBack. For example, the | ||
| // framework will call this automatically in a typical app when it has | ||
| // routes to pop. | ||
| onBackPressedCallback.setEnabled(false); |
There was a problem hiding this comment.
This is a potentially dangerous change. Does the framework guarantee that the callback will always be enabled when applicable via setFrameworkHandlesBack, regardless of API version?
| @@ -521,6 +521,7 @@ protected FlutterFragment createFlutterFragment() { | |||
| ? TransparencyMode.opaque | |||
| : TransparencyMode.transparent; | |||
| final boolean shouldDelayFirstAndroidViewDraw = renderMode == RenderMode.surface; | |||
| final boolean shouldAutomaticallyHandleOnBackPressed = Build.VERSION.SDK_INT >= 33; | |||
There was a problem hiding this comment.
With this change, you'll need to update the implementation of onBackPressed() below. On Android 33, the onBackPressed() method is still relevant, but it won't behave correctly without a call to super.onBackPressed().
Alternatively, you could make this condition always true and fully remove the onBackPressed() override below. That way you have less conditional behavior.
There was a problem hiding this comment.
I suppose removing the onBackPressed() override could impact behavior for any clients that subclass FlutterFragmentActivity and themselves override the method, but given that Android now formally discourages that anyways, that seems like a reasonable breaking change.
|
I spoke to @justinmc last week and he told me that he will get back to this one soon. |
|
I'll re-evaluate this after #49093 is merged. |
|
Spiritual successor: #52302 |
Following up on #39208 and #42789, which added predictive back support for FlutterActivity.
My test app for this is: https://github.com/justinmc/flutter-add-to-app
I tried this both with the Flutter app as the main activity, and with it as a secondary activity after an initial Android route. Predictive back worked in both cases.
Related: flutter/flutter#109558, and my comment flutter/flutter#109558 (comment).
b/242216228